Avoid traceback on Ctrl+C during interactive prompt #7042
+84
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {'y': True, 'n': False}, | ||
| process=str.lower, | ||
| ) | ||
| with handle_sigint(): |
There was a problem hiding this comment.
Why not use:
with suppress(KeyboardInterrupt):Or:
try:
...
except KeyboardInterrupt:
sys.exit(0)(As appropriate)
There was a problem hiding this comment.
I think that requires Ctrl+C twice while you are inside of the input() loop (or maybe doesn't work at all, can't remember), whereas this handles Ctrl+C immediately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes Ctrl+C during an interactive prompt more graceful - instead of giving traceback it will have the same effect as typing n+Enter
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.